fix: remove dummy data fallback in experiments_api.py render endpoint - #96
Open
ethan-long71 wants to merge 1 commit into
Open
fix: remove dummy data fallback in experiments_api.py render endpoint#96ethan-long71 wants to merge 1 commit into
ethan-long71 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dummy data fallback in experiments render endpoint
Problem: When no dataset is provided, the render figure endpoint was injecting dummy data
[{"_": 1}]instead of lettinggenerate_figureuse the experiment's own metrics as fallback.Solution: Pass
data_overridedirectly togenerate_figurewithout theor [{"'_'": 1}]fallback. The function already handlesNonecorrectly by using experiment metrics.Changes:
backend/app/modules/platform/experiments_api.py: Removed dummy data fallback on line 436Testing: 2 tests pass, verifying the dummy pattern is absent and data_override is passed through correctly.